PHP - If statement always evaluating as true?

radiocaf Published at Dev

radiocaf

So I can't get my head around this if statement.

What I am trying to do is get the person logged in from $_SESSION["user_name"] and if it matches one of two possible "admin" users, to give extra functionality. But it's always firing true.

For the example I'm going to have three users: Emma, John and Robert. Emma and John should be allowed the extra "admin functionality", but Robert is not allowed it. So...

My statement is:

if ($_SESSION["user_name"] === "emma" or "john"){
//give extra functionality as well as basic functionality
} else {
//give just basic functionality

But this is always firing true, so when I log in as my test account with the username Robert, he is also getting the extra functionality.

I've tried changing the quotation marks " of $_SESSION to apostrophes ', and also tried changing the operator from === to ==. I even tried = but found the hard way that this was setting my $_SESSION variable to "emma".

What am I doing wrong because I just can't seem to get my head around it?

If it's worth noting, this if statement is contained in a parent if statement that uses colons : and endif rather than brackets {}. The parent if statement is purely there to decide on what functionality to output based a column returned being empty or a user's name in there.

jpschroeder

You need to redeclare the full condition:

if ($_SESSION["user_name"] === "emma" or $_SESSION["user_name"] === "john"){
    //give extra functionality as well as basic functionality
} else {
   ...
}

Update With Explanation:

The pseudo code syntax for if statements is:

if ([some condition] [and/or] [another condition]) {
    // then do some stuff
}

each of those [condition] statements is evaluated as either "truthy" or "falsey". So your original question could be re-written something like this:

if ([$_SESSION["user_name"] is equal to "emma"] or ["john" is not false, 0, or null]) {
    // we will always get in here
}

Since "john" will always be "truthy" (it is not false, null, 0) it will always pass the condition.

Collected from the Internet

Please contact [email protected] to delete if infringement.

edited at2021-02-23

Comments

0 comments

From Dev

Related Related

Article

PHP - If statement always evaluating as true?

PHP - If statement always evaluating as true?

Why is this Smarty if statement always evaluating true?

if condition always evaluating true

PHP if statement always TRUE when comparing strings

PHP Why my 'if' statement always gives TRUE?

If or statement in php not evaluating correctly

If statement is always true

If statement always returning true?

PHP if statement evaluating to false, proceeds into executing true code. am i missing something?

Why is this if statement always returning true

'else if' statement always returns true

If statement always true with enum in comparison

Why is this if statement always returning true

pdo statement always return true

If statement always returning true in django

If statement is always coming up true

Evaluating requirements in python using string.isalpha, return always True

Evaluating requirements in python using string.isalpha, return always True

javascript/codecademy - if statement runs twice as false before evaluating true?

Why is this IF statement evaluating to false when all conditions are true?

Short hand if statement always returning true

If-statement always returning true in jQuery

Why is my JavaScript if statement always true?

First if statement always true, but second one is not

C++ GUI Condition for if statement always true

Why is this JavaScript if statement always returning true?

Simple if-else statement always returns true

How to make if statement always returns true for Rspec?

Greasemonkey: Why does this if statement always return true?

If statement always True Jinja2 Template